shervinrad100 commented on issue #43486:
URL: https://github.com/apache/airflow/issues/43486#issuecomment-2444848974
> I saw you want to commit to submitting a PR. I can assign it to you if
you want
Yes please would love to contribute and this seems like a quick fix anyway.
I was thinking of simply removing the default assignment. If you want
backward compatibility then I can add the following:
```
self.api_version = api_version
if self.api_version >= 17:
self.page_size = page_size or 10000
# warning message on deprecation. something like:
# warnings.warn("Setting a page_size in version v17 of the Google Ads
API will return an error. The earlier versions will change start throwing
errors on August 12, 2024.")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
