ferruzzi commented on code in PR #43456:
URL: https://github.com/apache/airflow/pull/43456#discussion_r1821404777
##########
providers/src/airflow/providers/amazon/aws/transfers/s3_to_dynamodb.py:
##########
@@ -237,10 +237,13 @@ def _load_into_existing_table(self) -> str:
total_items += page.get("Count", 0)
dynamodb_hook.write_batch_data(items=page["Items"])
self.log.info("Number of items loaded: %s", total_items)
+ except Exception as e:
+ # Does not raise errors to keep previous behavior.
Review Comment:
This comment implies that this is not a bug but a backward-compatability
choice. Based solely on that comment, this would appear to be a breaking
change, not a bugfix? Do we need to do a deprecation process for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
