ferruzzi commented on code in PR #43240: URL: https://github.com/apache/airflow/pull/43240#discussion_r1821624692
########## scripts/ci/docker-compose/integration-keycloak.yml: ########## @@ -0,0 +1,62 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +--- +services: + keycloak: + image: quay.io/keycloak/keycloak:23.0.6 + labels: + breeze.description: "Integration for manual testing multi-team Airflow." + entrypoint: /opt/keycloak/keycloak-entrypoint.sh + environment: + KC_HOSTNAME: localhost + KC_HOSTNAME_PORT: 38080 + KC_HOSTNAME_STRICT_BACKCHANNEL: false + KC_HTTP_ENABLED: true + KC_HOSTNAME_STRICT: true + + KEYCLOAK_ADMIN: admin + KEYCLOAK_ADMIN_PASSWORD: admin + + KC_DB: postgres + KC_DB_URL: jdbc:postgresql://postgres/keycloak + KC_DB_USERNAME: keycloak + KC_DB_PASSWORD: keycloak + ports: + - 38080:38080 Review Comment: I'm not sure if this is an issue or not, but 38080 is in use by the [Trino integration](https://github.com/apache/airflow/blob/main/scripts/ci/docker-compose/integration-trino.yml#L40) so they can't be used together with this mapping. I think we're fine, just pointing out the possible conflict. ########## scripts/ci/docker-compose/integration-keycloak.yml: ########## @@ -0,0 +1,62 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +--- +services: + keycloak: + image: quay.io/keycloak/keycloak:23.0.6 + labels: + breeze.description: "Integration for manual testing multi-team Airflow." Review Comment: Nit: awkward phrasing, maybe either "Integration for manual testing multi-team Airflow." or "Integration for manual testing of multi-team Airflow." might sound better? ########## dev/breeze/src/airflow_breeze/global_constants.py: ########## @@ -64,7 +64,8 @@ ALLOWED_ARCHITECTURES = [Architecture.X86_64, Architecture.ARM] # Database Backends used when starting Breeze. The "none" value means that invalid configuration # Is set and no database started - access to a database will fail. Review Comment: ```suggestion # Database Backends used when starting Breeze. The "none" value means that the # configuration is invalid and no database has started - access to a database will fail. ``` ########## scripts/ci/docker-compose/keycloak/keycloak-entrypoint.sh: ########## @@ -0,0 +1,43 @@ +#!/bin/bash + +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# We exit in case cd fails +cd /opt/keycloak/bin/ || exit + +# Start Keycloak in the background +./kc.sh start-dev --http-port=38080 & Review Comment: Could/should we be using the KC_HOSTNAME_PORT environment variable that you are creating in [scripts/ci/docker-compose/integration-keycloak.yml](https://github.com/apache/airflow/pull/43240/files#diff-e06ba92f98115758298308aff17e8fa62301ef34023a1fcaf7e3b7a4f288f512) instead of hardcoding it in here so many times? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
