pierrejeambrun commented on code in PR #43508:
URL: https://github.com/apache/airflow/pull/43508#discussion_r1822827784
##########
airflow/api_fastapi/core_api/routes/public/dag_run.py:
##########
@@ -104,6 +106,9 @@ async def patch_dag_run_state(
set_dag_run_state_to_queued(dag=dag, run_id=dag_run.run_id,
commit=True)
else:
set_dag_run_state_to_failed(dag=dag, run_id=dag_run.run_id,
commit=True)
+ elif attr_name == "note":
+ # Need to figure out how to get current user id
Review Comment:
We to not have any authentication yet in the new FastAPI API, so we cannot
retrieve the user.
I would suggest to include a comment there, and maybe open an issue to track
that, but for now to set the author to `None`. (The field is nullable in the
database). That issue can mention both `dag_run patch` and `task_instance
patch` because both of them will have that issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
