potiuk commented on code in PR #43555:
URL: https://github.com/apache/airflow/pull/43555#discussion_r1825169037
##########
dev/breeze/src/airflow_breeze/commands/setup_commands.py:
##########
@@ -255,8 +256,31 @@ def get_status(file: str):
get_console().print()
-def dict_hash(dictionary: dict[str, Any]) -> str:
+def dedent_help(dictionary: dict[str, Any]) -> None:
+ """
+ Dedent help stored in the dictionary.
+
+ Python 3.13 automatically dedents docstrings retrieved from functions.
+ See https://github.com/python/cpython/issues/81283
+
+ However, click uses docstrings in the absence of help strings, and we are
using click
+ command definition dictionary hash to detect changes in the command
definitions, so if the
+ help strings are not dedented, the hash will change.
+
+ That's why we must de-dent all the help strings in the command definition
dictionary
+ before we hash it.
Review Comment:
Yeah.... But it's about 1st Of November... Helloween. Spooky things
happening ..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
