potiuk commented on code in PR #43568:
URL: https://github.com/apache/airflow/pull/43568#discussion_r1825794512
##########
providers/tests/standard/utils/test_python_virtualenv.py:
##########
@@ -77,7 +74,7 @@ def test_should_create_virtualenv_with_system_packages(self,
mock_execute_in_sub
)
assert "/VENV/bin/python" == python_bin
mock_execute_in_subprocess.assert_called_once_with(
- [sys.executable, "-m", "virtualenv", "/VENV",
"--system-site-packages", "--python=pythonVER"]
+ ["pythonVER", "-m", "venv", "/VENV", "--system-site-packages"]
Review Comment:
```
venv_directory="/VENV", python_bin="pythonVER", system_site_packages=True,
requirements=[]
```
The thing there is that we cannot specify `--python` in venv because it can
only create a venv for it's own python version - so rather than passing
`--python` we have to run it via `pythonVER` interpreter :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
