ryanahamilton commented on code in PR #43523: URL: https://github.com/apache/airflow/pull/43523#discussion_r1825913104
########## airflow/ui/src/components/ui/index.ts: ########## @@ -0,0 +1,32 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +export { Dialog } from "./Dialog"; +export { Pagination } from "./Pagination"; +export { Select } from "./Select"; +export { Alert } from "./Alert"; +export { CloseButton } from "./CloseButton"; +export { InputGroup, type InputGroupProps } from "./InputGroup"; + +export { Switch } from "./Switch"; +export { Tag } from "./Tag"; +export { Tooltip } from "./Tooltip"; + +export { ProgressBar } from "./ProgressBar"; +export { Menu } from "./Menu"; Review Comment: This file might benefit from using wildcard exports, as it is going to continue to grow and input typing exports. ```suggestion export * from "./Dialog"; export * from "./Pagination"; export * from "./Select"; export * from "./Alert"; export * from "./CloseButton"; export * from "./InputGroup"; export * from "./Switch"; export * from "./Tag"; export *from "./Tooltip"; export * from "./ProgressBar"; export * from "./Menu"; ``` ########## airflow/ui/src/layouts/Nav/Nav.tsx: ########## @@ -43,49 +42,42 @@ export const Nav = () => ( position="fixed" py={3} top={0} - width={24} + width={20} zIndex={1} > <Flex alignItems="center" flexDir="column" width="100%"> - <Box - as={motion.div} - mb={3} - whileHover={{ - transform: ["rotate(0)", "rotate(360deg)"], - transition: { duration: 1.5, ease: "linear", repeat: Infinity }, - }} - > - <Icon as={AirflowPin} height="35px" width="35px" /> + <Box mb={3}> + <AirflowPin height="35px" width="35px" /> </Box> <NavButton icon={<FiHome size="1.75rem" />} title="Home" to="/" /> <NavButton - icon={<DagIcon height={7} width={7} />} + icon={<DagIcon height="1.75rem" width="1.75rem" />} title="Dags" to="dags" /> <NavButton + disabled icon={<FiDatabase size="1.75rem" />} - isDisabled title="Assets" to="assets" /> <NavButton + disabled icon={<FiGlobe size="1.75rem" />} - isDisabled title="Browse" to="browse" /> <NavButton + disabled icon={<FiSettings size="1.75rem" />} - isDisabled title="Admin" to="admin" /> </Flex> <Flex flexDir="column"> <NavButton - icon={<FiCornerUpLeft size="1.5rem" />} - title="Return to legacy UI" + icon={<FiCornerUpLeft size="1.75rem" />} + title="Legacy UI" Review Comment: Nice, I was going to make this suggestion previously. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
