amoghrajesh commented on code in PR #43601:
URL: https://github.com/apache/airflow/pull/43601#discussion_r1826547341
##########
providers/src/airflow/providers/cncf/kubernetes/operators/pod.py:
##########
@@ -388,7 +390,8 @@ def __init__(
self.priority_class_name = priority_class_name
self.pod_template_file = pod_template_file
self.pod_template_dict = pod_template_dict
- self.name = self._set_name(name)
+ name = self._set_name(name)
+ self.name = name
Review Comment:
+1, I do not think this is needed
##########
providers/src/airflow/providers/cncf/kubernetes/operators/pod.py:
##########
@@ -260,6 +260,8 @@ class KubernetesPodOperator(BaseOperator):
"env_from",
"node_selector",
"kubernetes_conn_id",
+ "name",
+ "hostname",
Review Comment:
Can you please add tests that cover this change in test_pod.py?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
