Lee-W commented on code in PR #43630:
URL: https://github.com/apache/airflow/pull/43630#discussion_r1827728392
##########
.github/workflows/build-images.yml:
##########
@@ -249,7 +249,7 @@ jobs:
pull-request-target: "true"
is-committer-build: ${{ needs.build-info.outputs.is-committer-build }}
push-image: "true"
- use-uv: ${{ needs.build-info.outputs.force-pip && 'false' || 'true' }}
+ use-uv: ${{ needs.build-info.outputs.force-pip=='true' && 'false' ||
'true' }}
Review Comment:
```suggestion
use-uv: ${{ needs.build-info.outputs.force-pip == 'true' && 'false' ||
'true' }}
```
##########
.github/workflows/build-images.yml:
##########
@@ -204,7 +204,7 @@ jobs:
pull-request-target: "true"
is-committer-build: ${{ needs.build-info.outputs.is-committer-build }}
push-image: "true"
- use-uv: ${{ needs.build-info.outputs.force-pip && 'false' || 'true' }}
+ use-uv: ${{ needs.build-info.outputs.force-pip=='true' && 'false' ||
'true' }}
Review Comment:
```suggestion
use-uv: ${{ needs.build-info.outputs.force-pip == 'true' && 'false' ||
'true' }}
```
nits: spaces seem to be used elsewhere 👀
##########
.github/workflows/finalize-tests.yml:
##########
@@ -149,7 +149,7 @@ jobs:
python-versions: ${{ inputs.python-versions }}
branch: ${{ inputs.branch }}
constraints-branch: ${{ inputs.constraints-branch }}
- use-uv: ${{ needs.build-info.outputs.force-pip && 'false' || 'true' }}
+ use-uv: ${{ needs.build-info.outputs.force-pip=='true' && 'false' ||
'true' }}
Review Comment:
```suggestion
use-uv: ${{ needs.build-info.outputs.force-pip == 'true' && 'false' ||
'true' }}
```
##########
.github/workflows/ci.yml:
##########
@@ -642,7 +642,7 @@ jobs:
kubernetes-versions-list-as-string: ${{
needs.build-info.outputs.kubernetes-versions-list-as-string }}
kubernetes-combos-list-as-string: ${{
needs.build-info.outputs.kubernetes-combos-list-as-string }}
include-success-outputs: ${{
needs.build-info.outputs.include-success-outputs }}
- use-uv: ${{ needs.build-info.outputs.force-pip && 'false' || 'true' }}
+ use-uv: ${{ needs.build-info.outputs.force-pip=='true' && 'false' ||
'true' }}
Review Comment:
```suggestion
use-uv: ${{ needs.build-info.outputs.force-pip == 'true' && 'false' ||
'true' }}
```
##########
.github/workflows/ci.yml:
##########
@@ -206,7 +206,7 @@ jobs:
platform: "linux/amd64"
python-versions: ${{ needs.build-info.outputs.python-versions }}
branch: ${{ needs.build-info.outputs.default-branch }}
- use-uv: ${{ needs.build-info.outputs.force-pip && 'false' || 'true' }}
+ use-uv: ${{ needs.build-info.outputs.force-pip=='true' && 'false' ||
'true' }}
Review Comment:
```suggestion
use-uv: ${{ needs.build-info.outputs.force-pip == 'true' && 'false' ||
'true' }}
```
##########
.github/workflows/ci.yml:
##########
@@ -559,7 +559,7 @@ jobs:
default-python-version: ${{
needs.build-info.outputs.default-python-version }}
branch: ${{ needs.build-info.outputs.default-branch }}
push-image: "true"
- use-uv: ${{ needs.build-info.outputs.force-pip && 'false' || 'true' }}
+ use-uv: ${{ needs.build-info.outputs.force-pip=='true' && 'false' ||
'true' }}
Review Comment:
```suggestion
use-uv: ${{ needs.build-info.outputs.force-pip == 'true' && 'false' ||
'true' }}
```
##########
.github/workflows/ci.yml:
##########
@@ -272,7 +272,7 @@ jobs:
latest-versions-only: ${{ needs.build-info.outputs.latest-versions-only
}}
include-success-outputs: ${{
needs.build-info.outputs.include-success-outputs }}
debug-resources: ${{ needs.build-info.outputs.debug-resources }}
- use-uv: ${{ needs.build-info.outputs.force-pip && 'false' || 'true' }}
+ use-uv: ${{ needs.build-info.outputs.force-pip=='true' && 'false' ||
'true' }}
Review Comment:
```suggestion
use-uv: ${{ needs.build-info.outputs.force-pip == 'true' && 'false' ||
'true' }}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
