Jarek Potiuk resolved AIRFLOW-5369.
    Fix Version/s: 1.10.6
       Resolution: Fixed

> Add interactivity to pre-commit image building
> ----------------------------------------------
>                 Key: AIRFLOW-5369
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5369
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: ci
>    Affects Versions: 2.0.0, 1.10.5
>            Reporter: Jarek Potiuk
>            Assignee: Jarek Potiuk
>            Priority: Major
>             Fix For: 1.10.6
> Currently when images are out-dated for pre-commit it just fails with message 
> how to re-run it with rebuild next time. Also when you already run 
> pre-commit, ^C does not work as expected - the main script is killed but the 
> docker images running the checks continue running in the background until 
> they finish. This is pretty annoying as killing such running docker 
> containers is not trivial and for pylint/mypy/flake we can run multiple 
> containers if we run it on many modified files. This is because wer are not 
> using dumb-init to run the checks.
> This is discouraging a bit, so instead a bit of interactivity can be added:
> 1) If image gets out-dated a question is asked whether to rebuild it while 
> pre-commit is executed
> 2) If you run pre-commit directly you do not get asked for rebuild because 
> you can run multiple pre-commit scripts in parallel  (pre-commit does it) so 
> you should fail fast (with helpful instructions)
> 3) If you run pre-commit via breeze, it is optimised because only the image 
> that is actually needed is rebuilt (and question is asked then)
> 4) Additionally - you should be able to press ^C and kill all containers 
> running in the background as well as the main script. 

This message was sent by Atlassian Jira

Reply via email to