uranusjr commented on code in PR #42913: URL: https://github.com/apache/airflow/pull/42913#discussion_r1828712387
########## airflow/models/dag_version.py: ########## @@ -0,0 +1,155 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from __future__ import annotations + +import logging +from typing import TYPE_CHECKING + +import uuid6 +from sqlalchemy import Column, ForeignKey, Integer, UniqueConstraint, func, select +from sqlalchemy.orm import relationship +from sqlalchemy_utils import UUIDType + +from airflow.models.base import Base, StringID +from airflow.utils import timezone +from airflow.utils.session import NEW_SESSION, provide_session +from airflow.utils.sqlalchemy import UtcDateTime, with_row_locks + +if TYPE_CHECKING: + from sqlalchemy.orm import Session + from sqlalchemy.sql import Select + +log = logging.getLogger(__name__) + + +class DagVersion(Base): + """Model to track the versions of DAGs in the database.""" + + __tablename__ = "dag_version" + id = Column(UUIDType(binary=False), primary_key=True, default=uuid6.uuid7) + version_number = Column(Integer, nullable=False, default=1) + version_name = Column(StringID()) + dag_id = Column(StringID(), ForeignKey("dag.dag_id", ondelete="CASCADE"), nullable=False) + dag_model = relationship("DagModel", back_populates="dag_versions") + dag_code = relationship( + "DagCode", + back_populates="dag_version", + uselist=False, + cascade="all, delete, delete-orphan", + cascade_backrefs=False, + ) + serialized_dag = relationship( + "SerializedDagModel", + back_populates="dag_version", + uselist=False, + cascade="all, delete, delete-orphan", + cascade_backrefs=False, + ) + dag_runs = relationship("DagRun", back_populates="dag_version", cascade="all, delete, delete-orphan") + task_instances = relationship("TaskInstance", back_populates="dag_version") + created_at = Column(UtcDateTime, default=timezone.utcnow) + + __table_args__ = ( + UniqueConstraint("dag_id", "version_number", name="dag_id_v_name_v_number_unique_constraint"), + ) + + def __repr__(self): + return f"<DagVersion {self.dag_id} {self.version}>" + + @classmethod + @provide_session + def write_dag( + cls, + *, + dag_id: str, + version_name: str | None = None, + version_number: int = 1, + session: Session = NEW_SESSION, + ) -> DagVersion: + """Write a new DagVersion into database.""" + existing_dag_version = session.scalar( + with_row_locks(cls._latest_version_select(dag_id), of=DagVersion, session=session, nowait=True) + ) + if existing_dag_version: + version_number = existing_dag_version.version_number + 1 + + dag_version = DagVersion( + dag_id=dag_id, + version_number=version_number, + version_name=version_name, + ) + log.debug("Writing DagVersion %s to the DB", dag_version) + session.add(dag_version) + # Flush is necessary here due to the unique constraint and other linked tables + session.flush() + log.debug("DagVersion %s written to the DB", dag_version) + return dag_version + + @classmethod + def _latest_version_select(cls, dag_id: str) -> Select: + return select(cls).where(cls.dag_id == dag_id).order_by(cls.created_at.desc()).limit(1) + + @classmethod + @provide_session + def get_latest_version(cls, dag_id: str, session: Session = NEW_SESSION) -> DagVersion | None: + return session.scalar(cls._latest_version_select(dag_id)) + + @classmethod + @provide_session + def get_version( + cls, + dag_id: str, + version_number: int = 1, + session: Session = NEW_SESSION, + ) -> DagVersion | None: + version_select_obj = ( + select(cls) + .where(cls.dag_id == dag_id, cls.version_number == version_number) + .order_by(cls.version_number.desc()) + .limit(1) + ) + return session.scalar(version_select_obj) + + @property + def version(self) -> str: + """Return the version name.""" Review Comment: There’s a `version_name` attribute that is “the version name” but this does not just return that. This docstring is probably more appropriate? ```suggestion """A human-friendly representation of the version.""" ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
