dstandish commented on code in PR #42689: URL: https://github.com/apache/airflow/pull/42689#discussion_r1829673307
########## airflow/dag_processing/bundles/base.py: ########## @@ -0,0 +1,86 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from __future__ import annotations + +import tempfile +from abc import ABC, abstractmethod +from pathlib import Path + +from airflow.configuration import conf + + +class BaseDagBundle(ABC): + """ + Base class for DAG bundles. + + DAG bundles are used both by the DAG processor and by a worker when running a task. These usage + patterns are different, however. + + When running a task, we know what version of the bundle we need (assuming the bundle supports versioning). + And we likely only need to keep this specific bundle version around for as long as we have tasks running using + that bundle version. This also means, that on a single worker, it's possible that multiple versions of the same + bundle are used at the same time. + + In contrast, the DAG processor uses a bundle to keep the DAGs from that bundle up to date. There will not be + multiple versions of the same bundle in use at the same time. The DAG processor will always use the latest version. Review Comment: ```suggestion multiple versions of the same bundle in use at the same time; the DAG processor will always use the latest version. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
