[
https://issues.apache.org/jira/browse/AIRFLOW-5147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16932655#comment-16932655
]
ASF GitHub Bot commented on AIRFLOW-5147:
-----------------------------------------
feng-tao commented on pull request #5819: [AIRFLOW-5147] extended character set
for for k8s worker pods annotations
URL: https://github.com/apache/airflow/pull/5819
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Annotations for k8s executors should support extended alphabet (like '/'))
> ---------------------------------------------------------------------------
>
> Key: AIRFLOW-5147
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5147
> Project: Apache Airflow
> Issue Type: Bug
> Components: executor-kubernetes, executors
> Affects Versions: 1.10.3, 1.10.4
> Reporter: Andrei Loginov
> Assignee: Daniel Imberman
> Priority: Major
>
> The fix to introduce k8s annotations for executors
> ([https://github.com/apache/airflow/pull/4589] for
> https://issues.apache.org/jira/browse/AIRFLOW-3766) limited the character set
> allowed for the annotation key to [-._a-zA-Z0-9] set. However many
> annotations contain `/` in it, for example:
> {code:java}
> injector.tumblr.com/request{code}
> or
> {code:java}
> iam.amazonaws.com/role{code}
> Which would not be allowed in the current solution.
>
> I believe original solution should be completely revisited. And instead of
> using a separate *kubernetes_annotations* section there should be a key which
> will contain a set of key:value annotations in some format. E.g. json:
> {code:java}
> [kubernetes]
> annotations = { "iam.amazonaws.com/role":
> "arn:aws:iam:::role/some-role-CKU5HL9BIPXG", "some-other-anno-key":
> "some/value" }
> {code}
>
> Supported character set for annotations:
> https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/#syntax-and-character-set
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
