vincbeck commented on code in PR #43763:
URL: https://github.com/apache/airflow/pull/43763#discussion_r1831491596
##########
providers/tests/openlineage/plugins/test_utils.py:
##########
@@ -428,7 +427,7 @@ def test_serialize_timetable_2_9():
@pytest.mark.skipif(
- not AIRFLOW_V_2_8_PLUS or AIRFLOW_V_2_9_PLUS,
+ AIRFLOW_V_2_9_PLUS,
reason="This test checks serialization only in 2.8 conditions",
)
def test_serialize_timetable_2_8():
Review Comment:
```suggestion
reason="This test checks serialization only in 2.9 conditions",
)
def test_serialize_timetable_2_9():
```
##########
contributing-docs/testing/unit_tests.rst:
##########
@@ -1173,10 +1173,10 @@ are not part of the public API. We deal with it in one
of the following ways:
.. code-block:: python
- from tests_common.test_utils.compat import AIRFLOW_V_2_8_PLUS
+ from tests_common.test_utils.compat import AIRFLOW_V_2_9_PLUS
- @pytest.mark.skipif(not AIRFLOW_V_2_8_PLUS, reason="The tests should be
skipped for Airflow < 2.8")
+ @pytest.mark.skipif(not AIRFLOW_V_2_9_PLUS, reason="The tests should be
skipped for Airflow < 2.9")
def some_test_that_only_works_for_airflow_2_8_plus():
Review Comment:
```suggestion
def some_test_that_only_works_for_airflow_2_9_plus():
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
