Lee-W commented on code in PR #42404:
URL: https://github.com/apache/airflow/pull/42404#discussion_r1832256503
##########
airflow/api_connexion/schemas/dag_run_schema.py:
##########
@@ -109,9 +101,9 @@ def autogenerate(self, data, **kwargs):
@post_dump
def autofill(self, data, **kwargs):
- """Populate execution_date from logical_date for compatibility."""
+ """Populate logical_date from logical_date for compatibility."""
ret_data = {}
- data["execution_date"] = data["logical_date"]
+ data["logical_date"] = data["logical_date"]
Review Comment:
Do we still need this line?
##########
airflow/api/common/mark_tasks.py:
##########
@@ -344,27 +318,15 @@ def set_dag_run_state_to_failed(
Set for a specific execution date and its task instances to failed.
:param dag: the DAG of which to alter state
- :param execution_date: the execution date from which to start
looking(deprecated)
:param run_id: the DAG run_id to start looking from
:param commit: commit DAG and tasks to be altered to the database
:param session: database session
:return: If commit is true, list of tasks that have been updated,
otherwise list of tasks that will be updated
- :raises: AssertionError if dag or execution_date is invalid
+ :raises: AssertionError if dag or logical_date is invalid
Review Comment:
Do we still need to raise something for `logical_date`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
