kosteev commented on code in PR #43762:
URL: https://github.com/apache/airflow/pull/43762#discussion_r1832377618
##########
providers/src/airflow/providers/cncf/kubernetes/operators/pod.py:
##########
@@ -563,7 +563,7 @@ def log_matching_pod(self, pod: k8s.V1Pod, context:
Context) -> None:
def get_or_create_pod(self, pod_request_obj: k8s.V1Pod, context: Context)
-> k8s.V1Pod:
if self.reattach_on_restart:
- pod = self.find_pod(self.namespace or
pod_request_obj.metadata.namespace, context=context)
+ pod = self.find_pod(pod_request_obj.metadata.namespace or
self.namespace, context=context) # type: ignore
Review Comment:
It seems to me that we do not need to consider "self.namespace" here at all.
As pod_request_obj.metadata.namespace will take into account self.namespace
while pod_request_obj will be generated. Can you, please, confirm this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
