Illumaria commented on PR #41916: URL: https://github.com/apache/airflow/pull/41916#issuecomment-2462297510
> @Illumaria I don't think the test failures are related to OL in any way, it's just you're calling method with default argument, in test do not pass the optional argument, and then it fails - because it uses default `False` argument. It does not pick up class member from `TrinoHook` or `PrestoHook` because nothing actually in the class `split_sql_string` refers to them. In the test (let's consider https://github.com/apache/airflow/blob/e342c510dfdd639fc2a4611e9273fd5a052bd7ca/providers/tests/presto/hooks/test_presto.py as an example) `test_split_sql_string` uses `self.db_hook`, which is an instance of `UnitTestPrestoHook`, which is derived from `airflow.providers.presto.hooks.presto.PrestoHook`, which is, in turn, derived from `airflow.providers.common.sql.hooks.sql.DbApiHook`, which implements static `split_sql_string` method with a default optional parameter introduced in this Pull Request. So no need to pass it explicitly in the test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
