romsharon98 commented on code in PR #43689:
URL: https://github.com/apache/airflow/pull/43689#discussion_r1833090508
##########
providers/tests/cncf/kubernetes/test_pod_generator.py:
##########
@@ -725,10 +642,7 @@ def test_deserialize_non_existent_model_file(self, caplog,
tmp_path):
),
)
def test_pod_name_confirm_to_max_length(self, input):
- with pytest.warns(
- AirflowProviderDeprecationWarning, match="Use `add_pod_suffix` in
`kubernetes_helper_functions`"
- ):
- actual = PodGenerator.make_unique_pod_id(input)
+ actual = add_unique_suffix(name=input, max_len=100)
Review Comment:
the default `max_len` in `add_unique_suffix` is 63 but when looking at
`make_unique_pod_id` the default is 100, I fix the test accordingly but wonder
if there is other solution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
