ianbuss opened a new pull request, #43817:
URL: https://github.com/apache/airflow/pull/43817

   FastAPI does not run Starlette lifespan events in mounted sub-applications 
by default (see 
[docs](https://fastapi.tiangolo.com/advanced/events/#sub-applications)), so we 
use the suggestion in [this 
issue](https://github.com/fastapi/fastapi/issues/811#issuecomment-1870030103) 
to run all mounted sub-application lifespans using an async context manager 
stack.
   
   To ensure that lifespan events are run in the TestApp we use a context 
manager for the test_app as outlined 
[here](https://www.starlette.io/lifespan/#running-lifespan-in-tests). To allow 
assertions about the lifespans we add a simple boolean variable to application 
state to indicate the lifespan has been run.
   
   <!-- Please keep an empty line above the dashes. -->
   ---
   **^ Add meaningful description above**
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a 
newsfragment file, named `{pr_number}.significant.rst` or 
`{issue_number}.significant.rst`, in 
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to