bbovenzi commented on PR #43793: URL: https://github.com/apache/airflow/pull/43793#issuecomment-2465703654
> Thanks @bbovenzi , I rebased the PR with latest main branch changes with fixes to scrolling and default state. Currently, clicking on events goes to `webapp/events` and does sorting by when in descending mode which is the default value. But there could be a situation where user doesn't want any sort and tries to click on `when` which causes the sorting to be empty but since sorting is empty the default sort supplied to `useTableURLState` still gets applied. User can sort by dag_id and then clicking on when will sort in asc order but once the user loads the page by default or reaches a state where no sorting is done it becomes which leads to confusion. This is slightly tricky for me to solve since default state of `sort=-when` is to be used when there is no sorting on page load but there could be legitimate use case where user wants no sorting at all including `sort=-when` . > > I guess maybe the link to events page in browse menu could be changed to `events?sort=-when` by default but I don't see any example in createBrowserRouter and it's not expected to match with query parameter as expected as per the comment [remix-run/react-router#9613 (comment)](https://github.com/remix-run/react-router/issues/9613#issuecomment-1320812151) > > https://reactrouter.com/en/main/routers/create-browser-router Oh ok so that's still a bug. If its manually set to be empty then it shouldn't fall back on the default. Let me fix that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
