jscheffl commented on code in PR #43494: URL: https://github.com/apache/airflow/pull/43494#discussion_r1835061458
########## providers/tests/microsoft/azure/triggers/test_powerbi.py: ########## @@ -39,19 +39,22 @@ @pytest.fixture -def powerbi_trigger(): - trigger = PowerBITrigger( - conn_id=POWERBI_CONN_ID, - proxies=None, - api_version=API_VERSION, - dataset_id=DATASET_ID, - group_id=GROUP_ID, - check_interval=CHECK_INTERVAL, - wait_for_termination=True, - timeout=TIMEOUT, - ) +def powerbi_trigger() -> PowerBITrigger: Review Comment: Thanks for the rework. Code looks good but... I was executing it locally and at least on my machine I still see runtimes at 30 seconds for two tasks: ``` ============================ slowest 100 durations ============================= 30.04s call providers/tests/microsoft/azure/triggers/test_powerbi.py::TestPowerBITrigger::test_powerbi_trigger_run_timeout[10] 30.03s call providers/tests/microsoft/azure/triggers/test_powerbi.py::TestPowerBITrigger::test_powerbi_trigger_run_timeout[0] 18.57s setup providers/tests/microsoft/azure/fs/test_adls.py::test_get_fs[mocked_connection0-expected_options0] 5.50s call providers/tests/microsoft/azure/triggers/test_wasb.py::TestWasbBlobSensorTrigger::test_waiting_for_blob ``` Anything that I need to setup locally to remove the 30s bottleneck? I also still see 30s runtime in CI results: https://github.com/apache/airflow/actions/runs/11744851979/job/32721562595?pr=43494#step:7:845 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
