jscheffl commented on PR #43367:
URL: https://github.com/apache/airflow/pull/43367#issuecomment-2466403574

   > A quick thoughts needed? For the type "configJson" should be use it as 
record or string. Using as record will further need to convert for usage of 
codemirror. if we use string we can handle that in backend maybe while API 
Calling or maybe while creating json for API, we can convert.
   > 
   > cc: @bbovenzi @jscheffl
   
   The current public REST API expects an JSON object as parameter for the 
conf, see 
https://airflow.apache.org/docs/apache-airflow/stable/stable-rest-api-ref.html#operation/post_dag_run
   Before adding a new API just to expect a string... I think it is easier to 
parse the JSON body from CodeMirror to JSON and use this for the trigger. Also 
has the benefit that you validate early and don't need to handle this 
explicitly from the server side.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to