This is an automated email from the ASF dual-hosted git repository.
jscheffl pushed a commit to branch v2-10-test
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/v2-10-test by this push:
new 20b6ab7e205 #43252 Disable extra links button if link is null or empty
(#43844) (#43851)
20b6ab7e205 is described below
commit 20b6ab7e2055f1eaa10b4fae38f2e57754324f98
Author: Jens Scheffler <[email protected]>
AuthorDate: Sat Nov 9 19:54:03 2024 +0100
#43252 Disable extra links button if link is null or empty (#43844) (#43851)
* Disable button if link is null or empty
* Fix space
---------
Co-authored-by: Enis Nazif <[email protected]>
(cherry picked from commit de8818270095d9f05edfec8e03daa5df7d6a773b)
Co-authored-by: enisnazif <[email protected]>
---
airflow/www/static/js/dag/details/taskInstance/ExtraLinks.tsx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/airflow/www/static/js/dag/details/taskInstance/ExtraLinks.tsx
b/airflow/www/static/js/dag/details/taskInstance/ExtraLinks.tsx
index 06528eab6e7..1eb59cb9b1a 100644
--- a/airflow/www/static/js/dag/details/taskInstance/ExtraLinks.tsx
+++ b/airflow/www/static/js/dag/details/taskInstance/ExtraLinks.tsx
@@ -55,7 +55,7 @@ const ExtraLinks = ({
const isSanitised = (url: string | null) => {
if (!url) {
- return true;
+ return false; // Empty or null urls should cause the link to be disabled
}
const urlRegex = /^(https?:)/i;
return urlRegex.test(url);
