mrk-andreev commented on code in PR #43853:
URL: https://github.com/apache/airflow/pull/43853#discussion_r1835548762
##########
providers/src/airflow/providers/cncf/kubernetes/operators/pod.py:
##########
@@ -157,7 +157,11 @@ class KubernetesPodOperator(BaseOperator):
:param labels: labels to apply to the Pod. (templated)
:param startup_timeout_seconds: timeout in seconds to startup the pod.
:param startup_check_interval_seconds: interval in seconds to check if the
pod has already started
+ :param get_init_containers_logs: get the stdout of the init containers as
logs of the tasks.
:param get_logs: get the stdout of the base container as logs of the tasks.
+ :param init_container_logs: list of init containers whose logs will be
published to stdout
+ Takes a sequence of containers, a single container name or True. If
True,
+ all the containers logs are published. Works in conjunction with
get_init_containers_logs param.
Review Comment:
Yes, you're right; we don't need get_init_containers_logs because for the
main containers, we log the base container, whereas for init containers, we
don't use this term.
So, I'd suggest using init_container_logs instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
