potiuk commented on code in PR #43784:
URL: https://github.com/apache/airflow/pull/43784#discussion_r1836547217
##########
providers/src/airflow/providers/ydb/hooks/ydb.py:
##########
@@ -136,12 +139,11 @@ class YDBHook(DbApiHook):
supports_autocommit: bool = True
supports_executemany: bool = True
- def __init__(self, *args, is_ddl: bool = False, use_scan_query: bool =
False, **kwargs) -> None:
+ def __init__(self, *args, is_ddl: bool = False, **kwargs) -> None:
Review Comment:
Those all look like breaking changes, can you make a note at the top of ydb
Changelog explaining that this is a breaking changes and summarizing changes
for the users ?
Then release manager will apply version change when preparing the
documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
