tirkarthi commented on PR #43888:
URL: https://github.com/apache/airflow/pull/43888#issuecomment-2468713944

   Thanks @bbovenzi for the comments. Did the following changes.
   
   1. Refactored `Metrics.tsx` to `HistoricalMetrics` folder with one component 
per file.
   2. Updated colors to use semantic codes.
   3. Added a custom badge component that can be updated so that the badge 
looks same across the components.
   
   > Eventually, we need a full date range selector instead of just a few 
preset dropdown options
   
   Agreed, it looks like Chakra doesn't have a datepicker component. So 
something like https://www.npmjs.com/package/react-datepicker can be used or 
one of the options from the discussion 
https://github.com/chakra-ui/chakra-ui/issues/580 . The datepicker can be a 
general component since it will be used across the app.
   
   Feel free to push to the branch if you have any changes directly too. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to