ashb commented on a change in pull request #6130: [AIRFLOW-5508] Add a 
whitelist mechanism for the StatsD metrics
URL: https://github.com/apache/airflow/pull/6130#discussion_r326060714
 
 

 ##########
 File path: scripts/ci/kubernetes/kube/templates/configmaps.template.yaml
 ##########
 @@ -54,6 +54,9 @@ data:
     statsd_port = 8125
     statsd_prefix = airflow
 
+    # optional comma-separated prefix whitelist (e.g: 
scheduler,executor,dagrun)
+    statsd_whitelist =
 
 Review comment:
   It's been what we have done in the past (so probably can leave it for now) 
but it is in no way required. This configmap template provides the airflow.cfg 
for the pod, and airflow's config looks for the first match in
   
   1. airflow.cfg in the AIRFLOW_HOME
   2. default_airflow.cfg from the dist.
   
   Since we have updated the default we don't also need to update the configmap.
   
   But for consistency now it's okay.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to