jscheffl commented on PR #43737: URL: https://github.com/apache/airflow/pull/43737#issuecomment-2469252532
> Maybe we want this, maybe not - maybe it's a wrong abstraction. But at least it's worth to discuss it rather than merge the PR without discussing it. Fair. And it is a bit a pity that the "TaskInstance" object is not passed into the Executor interface, the calling method has all the fields available. So if the TaskInstance would be included in `execute_async` signature all would be there. For sure, don't mis-understand. We don't want to build an EdgeWorker "balcony" here. Would be great if other executors would have this as well. Was looking once about if this could be made for Celery as well but could not find an entry point w/o patching deep in celery :-D If you dislike the parameter - I assume this can be changed... main point is how more task context can be made available. For example "some" fields like priority, pool slots, labels, max_tries, pool, queue could be genericaly be added into the dict of `executor_config`... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
