kaxil commented on code in PR #43894: URL: https://github.com/apache/airflow/pull/43894#discussion_r1837981889
########## airflow/api_fastapi/execution_api/routes/__init__.py: ########## @@ -17,10 +17,11 @@ from __future__ import annotations from airflow.api_fastapi.common.router import AirflowRouter -from airflow.api_fastapi.execution_api.routes import connections, health, task_instance, variables +from airflow.api_fastapi.execution_api.routes import connections, health, task_instance, variables, xcoms execution_api_router = AirflowRouter() execution_api_router.include_router(connections.router, prefix="/connections", tags=["Connections"]) execution_api_router.include_router(health.router, tags=["Health"]) execution_api_router.include_router(task_instance.router, prefix="/task_instance", tags=["Task Instance"]) execution_api_router.include_router(variables.router, prefix="/variables", tags=["Variables"]) +execution_api_router.include_router(xcoms.router, prefix="/xcoms", tags=["XComs"]) Review Comment: :) -- I changed my mind again -- going to make it plural — so I don’t have to change it in future if we add list, collection get endpoints and the fact that Public API has it plural too, so for code consistency! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
