uranusjr commented on code in PR #43902:
URL: https://github.com/apache/airflow/pull/43902#discussion_r1839379068
##########
providers/src/airflow/providers/openlineage/plugins/adapter.py:
##########
@@ -128,11 +128,11 @@ def build_task_instance_run_id(
dag_id: str,
task_id: str,
try_number: int,
- execution_date: datetime,
+ logical_date: datetime,
Review Comment:
I did a quick search and at least
`providers/src/airflow/providers/dbt/cloud/utils/openlineage.py` calls this
function, so we need additional compatibility measures for different provider
version combinations.
It’s probably best to leave this function as-is for now (don’t change the
`execution_date` argument in this PR) and figure out the considerations later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
