Re: [PR] Add basic asyncio support [airflow]

Wed, 13 Nov 2024 05:27:12 -0800 


ashb commented on code in PR #43944:
URL: https://github.com/apache/airflow/pull/43944#discussion_r1840274819


##########
dev/breeze/tests/test_packages.py:
##########
@@ -221,6 +221,7 @@ def test_get_documentation_package_path():
             """
     "apache-airflow-providers-common-sql>=1.17.0",
     "apache-airflow>=2.8.0",
+    "asyncpg>=0.30.0",

Review Comment:
   Benchmark, so take with a pinch of salt, but 
https://pypi.org/project/asyncpg/
   
   > In our testing asyncpg is, on average, 5x faster than psycopg3.
   >
   > 
![](https://pypi-camo.freetls.fastly.net/cfd9ddf54ddaa3b325b4df42aec46c44e32219c2/68747470733a2f2f7261772e67697468756275736572636f6e74656e742e636f6d2f4d61676963537461636b2f6173796e6370672f6d61737465722f706572666f726d616e63652e706e673f66646463613430616230)
   
   That's def a big enough of a change that we should see if we notice any 
difference 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to