pierrejeambrun commented on code in PR #43874:
URL: https://github.com/apache/airflow/pull/43874#discussion_r1840363466
##########
airflow/api_fastapi/core_api/datamodels/assets.py:
##########
@@ -64,3 +64,45 @@ class AssetCollectionResponse(BaseModel):
assets: list[AssetResponse]
total_entries: int
+
+
+class DagRunAssetReference(BaseModel):
+ """Serializable version of the DagRunAssetReference ORM SqlAlchemyModel."""
Review Comment:
There is no model `DagRunAssetReference`, maybe you meant `DagRun`?
Maybe:
```suggestion
"""Basic DagRun serializer for responses."""
```
Also I would remove everywhere the mention of `ORM SqlAlchemyModel` because
the serializer can serialize much more than just an SQLAlchemy model. (any
arbitrary object with appropriate attributes, a plain dictionnary, etc...).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
