ashb commented on code in PR #43893: URL: https://github.com/apache/airflow/pull/43893#discussion_r1840338841
########## task_sdk/pyproject.toml: ########## @@ -46,11 +50,24 @@ namespace-packages = ["src/airflow"] # Ignore Doc rules et al for anything outside of tests "!src/*" = ["D", "TID253", "S101", "TRY002"] -"src/airflow/sdk/__init__.py" = ["TCH004"] +# Only have pytest rules in tests - https://github.com/astral-sh/ruff/issues/14205 Review Comment: That's not what it's asying though. `PT` is ignored outside of anyfile that doesn't start with `tests/` -- so `PT` rules only apply inside tests. ########## task_sdk/pyproject.toml: ########## @@ -46,11 +50,24 @@ namespace-packages = ["src/airflow"] # Ignore Doc rules et al for anything outside of tests "!src/*" = ["D", "TID253", "S101", "TRY002"] -"src/airflow/sdk/__init__.py" = ["TCH004"] +# Only have pytest rules in tests - https://github.com/astral-sh/ruff/issues/14205 Review Comment: Changed to say `# Ignore the pytest rules outside the tests folder - https://github.com/astral-sh/ruff/issues/14205 ` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
