ferruzzi commented on code in PR #43941:
URL: https://github.com/apache/airflow/pull/43941#discussion_r1840858125
##########
airflow/metrics/validators.py:
##########
@@ -82,7 +82,8 @@ class MetricNameLengthExemptionWarning(Warning):
}
BACK_COMPAT_METRIC_NAMES: set[Pattern[str]] = {re2.compile(name) for name in
BACK_COMPAT_METRIC_NAME_PATTERNS}
-OTEL_NAME_MAX_LENGTH = 63
+# According to otel spec, max length should be 255. Change if the spec gets
revised.
+OTEL_NAME_MAX_LENGTH = 255
Review Comment:
You can drop this for now. @ArshiaZr has a PR already going that is making
this fix.
FWIW, long story short, that was there because when I initially implemented
OTel Metrics there was a bug on their end that threw an exception if the name
was longer than that, but it appears to have been fixed at some point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
