potiuk commented on PR #43965:
URL: https://github.com/apache/airflow/pull/43965#issuecomment-2474956968
> Do we need to make the db/non-db part of the command (e.g. core-tests,
core-db-tests, core-non-db-tests)? It feels like we should have just one group
command and then an option to toggle db/non-db/both.
It makes it quite a bit easier to handle. DB paralel tests are run using
multi-processing and running parallel docker-composes. Where Non-DB parallel
tests are run using xdist. This makes the two commands pretty distinct - they
not only behave diferently but also they have various other parameters
applicable on in one of those cases (mostly the DB).
Those are the options that only make senses for DB tests:
* `--db-reset`
* `--backend`
* `--no-db-cleanup`
* `--postgres-version`
* `--mysql-version`
Thanks to that teh `non-db-tests` have way smaller set of parameter than
`db-tests`.
Technically we could pass all the necessary parametters for non-db option in
the "regular" (that handles both db and non-db) - parallelism, backend=none and
few others, But then that makes `non-db` commands way simpler when we select
which command to use based on parameters passed - for example:
```
if [[ "${TEST_SCOPE}" == "DB" ]]; then
set -x
breeze testing core-db-tests
set +x
elif [[ "${TEST_SCOPE}" == "Non-DB" ]]; then
set -x
breeze testing core-non-db-tests
set +x
```
I experimented with it before, and that one produced the nicest and simplest
set of commands to execute without specifying too many parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
