potiuk commented on PR #43979: URL: https://github.com/apache/airflow/pull/43979#issuecomment-2477121441
@ashb > Interface question should the db/non-db be a flag that operates like a filter, so something like breeze testing core-tests --non-db etc? @vincbeck > > I agree, a flag to filter db/non-db tests would make more sense to me instead of having separate commands OK. That's the 3rd similar comment after @o-nikolas - and I explained the reasons in: https://github.com/apache/airflow/pull/43965#issuecomment-2474956968 So if everyone around you seems to be mad, maybe it's you :) It's really additional level of abstraction for the base command that makes it easier to run and has some defaults set differently, but it is all possible to be done with the base command - it's just a matter to pass a few more parameters. And it was meant as "easier to reproduce locally" - in CI I can easily make those commands more complex. Let me try to remove it and see how it will be then, that's not a big change and will decrease amount of code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
