jscheffl commented on code in PR #43681:
URL: https://github.com/apache/airflow/pull/43681#discussion_r1842793430
##########
providers/tests/amazon/aws/log/test_s3_task_handler.py:
##########
@@ -129,7 +129,8 @@ def test_read(self):
log, metadata = self.s3_task_handler.read(ti)
actual = log[0][0][-1]
expected = "*** Found logs in s3:\n*** *
s3://bucket/remote/log/location/1.log\nLog line"
Review Comment:
Just a small glitch, then I assume it is good to go:
```
providers/tests/amazon/aws/log/test_s3_task_handler.py:131:9: F841 Local
variable `expected` is assigned to but never used
|
129 | log, metadata = self.s3_task_handler.read(ti)
130 | actual = log[0][0][-1]
131 | expected = "*** Found logs in s3:\n*** *
s3://bucket/remote/log/location/1.log\nLog line"
| ^^^^^^^^ F841
132 | assert "*** Found logs in s3:\n*** *
s3://bucket/remote/log/location/1.log\n" in actual
133 | assert actual.endswith("Log line")
|
= help: Remove assignment to unused variable `expected`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
