o-nikolas commented on PR #42587: URL: https://github.com/apache/airflow/pull/42587#issuecomment-2477554923
> > > Could you add a unit test for it? > > > > > > I took a look at adding one, but there is no existing coverage for this error handling code and it wasn't obvious to me how to write it due to the async nature of the feature embedded in a private method. > > Did you check > > https://github.com/apache/airflow/blob/857ca4c06c9008593674cabdd28d3c30e3e7f97b/providers/tests/amazon/aws/triggers/test_ecs.py#L37 > ? Agreed with @vincbeck and @eladkal You can start with the test class that Elad linked. The logs hook is already being mocked, you just need to update the return value of the call to get logs to return your exception that you're handling. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
