uranusjr commented on code in PR #43826:
URL: https://github.com/apache/airflow/pull/43826#discussion_r1843621102
##########
airflow/assets/__init__.py:
##########
@@ -276,20 +279,43 @@ class Asset(os.PathLike, BaseAsset):
uri: str
group: str
extra: dict[str, Any]
+ watchers: list[BaseTrigger]
asset_type: ClassVar[str] = "asset"
__version__: ClassVar[int] = 1
@overload
- def __init__(self, name: str, uri: str, *, group: str = "", extra: dict |
None = None) -> None:
+ def __init__(
+ self,
+ name: str,
+ uri: str,
+ *,
+ group: str = "",
+ extra: dict | None = None,
+ watchers: list[BaseTrigger] | None = None,
Review Comment:
How is this argument supposed to be used? This class is a user-facing
interface; do we expect users to pass in triggers manually when they create an
asset? If not, we should not add this argument here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
