This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new bf124d0b2bf Fix special tests in the new workflow structure (#44083)
bf124d0b2bf is described below
commit bf124d0b2bf5d9be9694c132f92c3770b7099837
Author: Jarek Potiuk <[email protected]>
AuthorDate: Sat Nov 16 05:09:13 2024 +0100
Fix special tests in the new workflow structure (#44083)
When #43979 there was a typo where inputs passed as test-groups
were not passed to unit tests in "special-tests" case - because
the "needs.build-info.outputs" were used instead.
Unfortunately this is not caught by GitHub parsing the workflows,
it will only signal it by having annotations of errors on the
affected actions - missing needs.build-info entries are simply
replaced by empty string.
---
.github/workflows/ci.yml | 1 +
.github/workflows/special-tests.yml | 30 +++++++++++++++++-------------
2 files changed, 18 insertions(+), 13 deletions(-)
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 96996a42ee1..eb594ff3764 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -501,6 +501,7 @@ jobs:
excluded-providers-as-string: ${{
needs.build-info.outputs.excluded-providers-as-string }}
canary-run: ${{ needs.build-info.outputs.canary-run }}
upgrade-to-newer-dependencies: ${{
needs.build-info.outputs.upgrade-to-newer-dependencies }}
+ include-success-outputs: ${{
needs.build-info.outputs.include-success-outputs }}
debug-resources: ${{ needs.build-info.outputs.debug-resources }}
tests-integration-system:
diff --git a/.github/workflows/special-tests.yml
b/.github/workflows/special-tests.yml
index 012b619cba9..9ff5afeeaf1 100644
--- a/.github/workflows/special-tests.yml
+++ b/.github/workflows/special-tests.yml
@@ -68,6 +68,10 @@ on: # yamllint disable-line rule:truthy
description: "Whether to upgrade to newer dependencies or not
(true/false)"
required: true
type: string
+ include-success-outputs:
+ description: "Whether to include success outputs or not (true/false)"
+ required: true
+ type: string
debug-resources:
description: "Whether to debug resources or not (true/false)"
required: true
@@ -85,7 +89,7 @@ jobs:
downgrade-sqlalchemy: "true"
test-name: "MinSQLAlchemy-Postgres"
test-scope: "DB"
- test-groups: ${{ needs.build-info.outputs.test-groups }}
+ test-groups: ${{ inputs.test-groups }}
backend: "postgres"
image-tag: ${{ inputs.image-tag }}
python-versions: "['${{ inputs.default-python-version }}']"
@@ -109,7 +113,7 @@ jobs:
upgrade-boto: "true"
test-name: "LatestBoto-Postgres"
test-scope: "All"
- test-groups: ${{ needs.build-info.outputs.test-groups }}
+ test-groups: ${{ inputs.test-groups }}
backend: "postgres"
image-tag: ${{ inputs.image-tag }}
python-versions: "['${{ inputs.default-python-version }}']"
@@ -118,7 +122,7 @@ jobs:
excludes: "[]"
core-test-types-list-as-string: ${{
inputs.core-test-types-list-as-string }}
providers-test-types-list-as-string: ${{
inputs.providers-test-types-list-as-string }}
- include-success-outputs: ${{
needs.build-info.outputs.include-success-outputs }}
+ include-success-outputs: ${{ inputs.include-success-outputs }}
run-coverage: ${{ inputs.run-coverage }}
debug-resources: ${{ inputs.debug-resources }}
@@ -134,7 +138,7 @@ jobs:
downgrade-pendulum: "true"
test-name: "Pendulum2-Postgres"
test-scope: "All"
- test-groups: ${{ needs.build-info.outputs.test-groups }}
+ test-groups: ${{ inputs.test-groups }}
backend: "postgres"
image-tag: ${{ inputs.image-tag }}
python-versions: "['${{ inputs.default-python-version }}']"
@@ -143,7 +147,7 @@ jobs:
excludes: "[]"
core-test-types-list-as-string: ${{
inputs.core-test-types-list-as-string }}
providers-test-types-list-as-string: ${{
inputs.providers-test-types-list-as-string }}
- include-success-outputs: ${{
needs.build-info.outputs.include-success-outputs }}
+ include-success-outputs: ${{ inputs.include-success-outputs }}
run-coverage: ${{ inputs.run-coverage }}
debug-resources: ${{ inputs.debug-resources }}
@@ -159,7 +163,7 @@ jobs:
enable-aip-44: "false"
test-name: "InProgressDisabled-Postgres"
test-scope: "All"
- test-groups: ${{ needs.build-info.outputs.test-groups }}
+ test-groups: ${{ inputs.test-groups }}
backend: "postgres"
image-tag: ${{ inputs.image-tag }}
python-versions: "['${{ inputs.default-python-version }}']"
@@ -168,7 +172,7 @@ jobs:
excludes: "[]"
core-test-types-list-as-string: ${{
inputs.core-test-types-list-as-string }}
providers-test-types-list-as-string: ${{
inputs.providers-test-types-list-as-string }}
- include-success-outputs: ${{
needs.build-info.outputs.include-success-outputs }}
+ include-success-outputs: ${{ inputs.include-success-outputs }}
run-coverage: ${{ inputs.run-coverage }}
debug-resources: ${{ inputs.debug-resources }}
@@ -183,7 +187,7 @@ jobs:
runs-on-as-json-default: ${{ inputs.runs-on-as-json-default }}
test-name: "Postgres"
test-scope: "Quarantined"
- test-groups: ${{ needs.build-info.outputs.test-groups }}
+ test-groups: ${{ inputs.test-groups }}
backend: "postgres"
image-tag: ${{ inputs.image-tag }}
python-versions: "['${{ inputs.default-python-version }}']"
@@ -192,7 +196,7 @@ jobs:
excludes: "[]"
core-test-types-list-as-string: ${{
inputs.core-test-types-list-as-string }}
providers-test-types-list-as-string: ${{
inputs.providers-test-types-list-as-string }}
- include-success-outputs: ${{
needs.build-info.outputs.include-success-outputs }}
+ include-success-outputs: ${{ inputs.include-success-outputs }}
run-coverage: ${{ inputs.run-coverage }}
debug-resources: ${{ inputs.debug-resources }}
@@ -207,7 +211,7 @@ jobs:
runs-on-as-json-default: ${{ inputs.runs-on-as-json-default }}
test-name: "Postgres"
test-scope: "ARM collection"
- test-groups: ${{ needs.build-info.outputs.test-groups }}
+ test-groups: ${{ inputs.test-groups }}
backend: "postgres"
image-tag: ${{ inputs.image-tag }}
python-versions: "['${{ inputs.default-python-version }}']"
@@ -216,7 +220,7 @@ jobs:
excludes: "[]"
core-test-types-list-as-string: ${{
inputs.core-test-types-list-as-string }}
providers-test-types-list-as-string: ${{
inputs.providers-test-types-list-as-string }}
- include-success-outputs: ${{
needs.build-info.outputs.include-success-outputs }}
+ include-success-outputs: ${{ inputs.include-success-outputs }}
run-coverage: ${{ inputs.run-coverage }}
debug-resources: ${{ inputs.debug-resources }}
@@ -231,7 +235,7 @@ jobs:
runs-on-as-json-default: ${{ inputs.runs-on-as-json-default }}
test-name: "SystemTest"
test-scope: "System"
- test-groups: ${{ needs.build-info.outputs.test-groups }}
+ test-groups: ${{ inputs.test-groups }}
backend: "postgres"
image-tag: ${{ inputs.image-tag }}
python-versions: "['${{ inputs.default-python-version }}']"
@@ -240,6 +244,6 @@ jobs:
excludes: "[]"
core-test-types-list-as-string: ${{
inputs.core-test-types-list-as-string }}
providers-test-types-list-as-string: ${{
inputs.providers-test-types-list-as-string }}
- include-success-outputs: ${{
needs.build-info.outputs.include-success-outputs }}
+ include-success-outputs: ${{ inputs.include-success-outputs }}
run-coverage: ${{ inputs.run-coverage }}
debug-resources: ${{ inputs.debug-resources }}
