jscheffl commented on code in PR #43520:
URL: https://github.com/apache/airflow/pull/43520#discussion_r1844943356
##########
airflow/executors/base_executor.py:
##########
@@ -552,7 +554,12 @@ def terminate(self):
"""Get called when the daemon receives a SIGTERM."""
raise NotImplementedError
- def cleanup_stuck_queued_tasks(self, tis: list[TaskInstance]) ->
list[str]: # pragma: no cover
+ @deprecated(
Review Comment:
@dstandish
As this is a change of (public) API of BaseExecutor, are you back-porting
this to `v2-10-test` branch (the Interface change) to know that other executor
implementations need to adjust?
Otherwise, is this PR in general a bug-fix that would be valid to be ported
to 2.10-line of Airflow or is this treated as new feature for Airflow 3? (I see
this as 70% a bug fix for operational problem improvement and 30% a feature
that myself I always found missing but never made it to the idea to contribute
myself).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
