kaxil commented on code in PR #43865:
URL: https://github.com/apache/airflow/pull/43865#discussion_r1844970805
##########
dev/breeze/src/airflow_breeze/params/shell_params.py:
##########
@@ -501,7 +501,12 @@ def env_variables_for_docker_commands(self) -> dict[str,
str]:
_env, "AIRFLOW__CORE__EXECUTOR",
"airflow.providers.edge.executors.edge_executor.EdgeExecutor"
)
_set_var(_env, "AIRFLOW__EDGE__API_ENABLED", "true")
- _set_var(_env, "AIRFLOW__EDGE__API_URL",
"http://localhost:8080/edge_worker/v1/rpcapi";)
+ if self.use_airflow_version and
self.use_airflow_version.startswith("2."):
+ # Airflow 2.10 runs it in the webserver atm
+ _set_var(_env, "AIRFLOW__EDGE__API_URL",
"http://localhost:8080/edge_worker/v1/rpcapi";)
+ else:
+ # Dev Airflow 3 runs API on FastAPI transitional
+ _set_var(_env, "AIRFLOW__EDGE__API_URL",
"http://localhost:9091/edge_worker/v1/rpcapi";)
Review Comment:
```suggestion
# Dev Airflow 3 runs API on FastAPI transitional
port = 9091
if self.use_airflow_version and
self.use_airflow_version.startswith("2."):
# Airflow 2.10 runs it in the webserver atm
port = 8080
_set_var(_env, "AIRFLOW__EDGE__API_URL",
f"http://localhost:{port}/edge_worker/v1/rpcapi";)
```
##########
providers/src/airflow/providers/edge/worker_api/app.py:
##########
@@ -0,0 +1,38 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from __future__ import annotations
+
+from fastapi import FastAPI
+
+from airflow.providers.edge.worker_api.routes.health import health_router
+from airflow.providers.edge.worker_api.routes.rpc_api import rpc_api_router
+
+
+def create_edge_worker_api_app() -> FastAPI:
+ """Create FastAPI app for edge worker API."""
+ edge_worker_api_app = FastAPI(
+ title="Airflow Edge Worker API",
+ description="This is Airflow Edge Worker API - which is a the access
endpoint for workers running on "
+ "remote sites serving for Apache Airflow jobs. It also proxies
internal API to edge endpoints. "
+ "It is not intended to be used by any external code. "
+ "You can find more information in AIP-69 "
+
"https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=301795932";,
+ )
Review Comment:
```suggestion
description=(
"This is Airflow Edge Worker API - which is a the access
endpoint for workers running on "
"remote sites serving for Apache Airflow jobs. It also proxies
internal API to edge endpoints. "
"It is not intended to be used by any external code. "
"You can find more information in AIP-69 "
"https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=301795932";
),
)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
