bugraoz93 commented on PR #43329: URL: https://github.com/apache/airflow/pull/43329#issuecomment-2480851712
While reviewing the logs to ensure everything was running smoothly, I noticed an issue: I had accidentally reversed the -+e option 🤦♂️. However, I encountered the following error: >#50 2.616 /scripts/docker/install_yarn_dependencies_from_branch_tip.sh: line 21: yarn: command not found This suggests that yarn was either not installed or unavailable in the environment when the script was executed. This made me realize that `npm` and `yarn` should have been installed at the point when the script is executed. I identified the best place to install them using apt and to cache them just before switching to the `airflow` user. Since `yarn` installs `node_modules` to a local directory, I copied the installed dependencies to a cache directory for future use. Once the cache was utilized in the appropriate location, it was deleted during the execution of `compile_www_assets.py` to ensure it was not included in the final package. > Looks good, but we also have to handle UI dependencies (with pnpm) Indeed, thanks for pointing that out! I wanted to make sure everything was functioning as expected before implementing a similar solution with `pnpm`. That’s the next step I’ll tackle. Many thanks for the quick review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
