uranusjr commented on code in PR #43773:
URL: https://github.com/apache/airflow/pull/43773#discussion_r1845893076
##########
task_sdk/tests/defintions/test_asset.py:
##########
@@ -645,35 +648,3 @@ def test_only_posarg(self, subcls, group, arg):
assert obj.name == arg
assert obj.uri == arg
assert obj.group == group
-
-
[email protected](
- "module_path, attr_name, warning_message",
- (
- (
- "airflow",
- "Dataset",
- (
- "Import 'Dataset' directly from the airflow module is
deprecated and will be removed in the future. "
- "Please import it from 'airflow.assets.Dataset'."
- ),
- ),
- (
- "airflow.datasets",
- "Dataset",
- (
- "Import from the airflow.dataset module is deprecated and "
- "will be removed in the Airflow 3.2. Please import it from
'airflow.assets'."
- ),
- ),
- ),
-)
-def test_backward_compat_import_before_airflow_3_2(module_path, attr_name,
warning_message):
- with pytest.warns() as record:
- import importlib
-
- mod = importlib.import_module(module_path, __name__)
- getattr(mod, attr_name)
-
- assert record[0].category is DeprecationWarning
- assert str(record[0].message) == warning_message
Review Comment:
I believe imports directly from `airflow` should still work (@ashb can
clarify the expectation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
