pierrejeambrun commented on code in PR #44069:
URL: https://github.com/apache/airflow/pull/44069#discussion_r1846202744
##########
tests/api_fastapi/core_api/routes/public/test_assets.py:
##########
@@ -424,6 +475,68 @@ def test_limit_and_offset(self, test_client, params,
expected_asset_uris):
asset_uris = [asset["uri"] for asset in
response.json()["asset_events"]]
assert asset_uris == expected_asset_uris
+ @pytest.mark.usefixtures("time_freezer")
+ @pytest.mark.enable_redact
+ def test_should_mask_sensitive_extra_logs(self, test_client, session):
Review Comment:
Not sure why we have `logs` in the name of the test, I don't think we assert
any `Log` here.
##########
tests/api_fastapi/core_api/routes/public/test_assets.py:
##########
@@ -463,17 +576,29 @@ def test_should_respond_404(self, test_client):
assert response.status_code == 404
assert response.json()["detail"] == "The Asset with uri:
`s3://bucket/key` was not found"
+ @pytest.mark.usefixtures("time_freezer")
+ @pytest.mark.enable_redact
+ def test_should_mask_sensitive_extra_logs(self, test_client, session):
Review Comment:
same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]