pierrejeambrun commented on code in PR #44074: URL: https://github.com/apache/airflow/pull/44074#discussion_r1846352112
########## airflow/ui/src/pages/DagsList/Dag/Overview/Overview.tsx: ########## @@ -0,0 +1,96 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { Box, HStack, Badge, Text, Skeleton } from "@chakra-ui/react"; +import dayjs from "dayjs"; +import { useState } from "react"; +import { Link, useLocation, useParams } from "react-router-dom"; + +import { useTaskInstanceServiceGetTaskInstances } from "openapi/queries"; +import TimeRangeSelector from "src/components/TimeRangeSelector"; +import { pluralize } from "src/utils"; +import { stateColor } from "src/utils/stateColor"; + +import { Chart } from "./Chart"; + +const defaultHour = "8"; + +export const Overview = () => { + const { dagId } = useParams(); + + const now = dayjs(); + const [startDate, setStartDate] = useState( + now.subtract(Number(defaultHour), "hour").toISOString(), + ); + const [endDate, setEndDate] = useState(now.toISOString()); + + const { data: failedTasks, isLoading } = + useTaskInstanceServiceGetTaskInstances({ + dagId: dagId ?? "", + dagRunId: "~", + logicalDateGte: startDate, + logicalDateLte: endDate, + state: ["failed"], + }); + + const location = useLocation(); + + // TODO actually link to task instances list + return ( + <Box m={4}> + <Box my={2}> + <TimeRangeSelector + defaultValue={defaultHour} + endDate={endDate} + setEndDate={setEndDate} + setStartDate={setStartDate} + startDate={startDate} + /> + </Box> + {failedTasks?.total_entries !== undefined && + failedTasks.total_entries > 0 ? ( Review Comment: I think we should still display the graph with a flat `0` line if there are no failed task. In its current state the graph is just not displayed with can be a little surprising. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
