amoghrajesh commented on code in PR #44129:
URL: https://github.com/apache/airflow/pull/44129#discussion_r1846497152
##########
tests/api_fastapi/core_api/routes/public/test_assets.py:
##########
@@ -464,16 +479,77 @@ def test_should_respond_404(self, test_client):
assert response.json()["detail"] == "The Asset with uri:
`s3://bucket/key` was not found"
-class TestPostAssetEvents(TestAssets):
- @pytest.fixture
- def time_freezer(self) -> Generator:
- freezer = time_machine.travel(self.default_time, tick=False)
- freezer.start()
+class TestQueuedEventEndpoint(TestAssets):
+ def _create_asset_dag_run_queues(self, dag_id, asset_id, session):
+ adrq = AssetDagRunQueue(target_dag_id=dag_id, asset_id=asset_id)
+ session.add(adrq)
+ session.commit()
+ return adrq
- yield
- freezer.stop()
+class TestGetDagAssetQueuedEvents(TestQueuedEventEndpoint):
+ @pytest.mark.usefixtures("time_freezer")
+ def test_should_respond_200(self, test_client, session, create_dummy_dag):
+ dag, _ = create_dummy_dag()
+ dag_id = dag.dag_id
+ self.create_assets(session=session, num=1)
+ asset_id = 1
+ self._create_asset_dag_run_queues(dag_id, asset_id, session)
+
+ response = test_client.get(
+ f"/public/dags/{dag_id}/assets/queuedEvent",
+ )
+
+ assert response.status_code == 200
+ assert response.json() == {
+ "queued_events": [
+ {
+ "created_at": self.default_time.replace("+00:00", "Z"),
+ "uri": "s3://bucket/key/1",
+ "dag_id": "dag",
+ }
+ ],
+ "total_entries": 1,
+ }
+
+ def test_should_respond_404(self, test_client):
+ dag_id = "not_exists"
+
+ response = test_client.get(
+ f"/public/dags/{dag_id}/assets/queuedEvent",
+ )
+
+ assert response.status_code == 404
+ assert response.json()["detail"] == "Queue event with dag_id:
`not_exists` was not found"
+
+class TestDeleteDagDatasetQueuedEvents(TestQueuedEventEndpoint):
+ @pytest.mark.usefixtures("time_freezer")
+ def test_should_respond_204(self, test_client, session, create_dummy_dag):
+ dag, _ = create_dummy_dag()
+ dag_id = dag.dag_id
+ self.create_assets(session=session, num=1)
+ asset_id = 1
+ self._create_asset_dag_run_queues(dag_id, asset_id, session)
+
+ response = test_client.delete(
+ f"/public/dags/{dag_id}/assets/queuedEvent",
+ )
+
+ assert response.status_code == 204
+
+ def test_should_respond_404(self, test_client):
+ dag_id = "not_exists"
+
+ response = test_client.delete(
+ f"/public/dags/{dag_id}/assets/queuedEvent",
Review Comment:
I pushed a new test case that should cover this
##########
tests/api_fastapi/core_api/routes/public/test_assets.py:
##########
@@ -523,6 +523,32 @@ def test_should_respond_404(self, test_client):
assert response.json()["detail"] == "Queue event with dag_id:
`not_exists` was not found"
+class TestDeleteDagDatasetQueuedEvents(TestQueuedEventEndpoint):
+ @pytest.mark.usefixtures("time_freezer")
+ def test_should_respond_204(self, test_client, session, create_dummy_dag):
+ dag, _ = create_dummy_dag()
+ dag_id = dag.dag_id
+ self.create_assets(session=session, num=1)
+ asset_id = 1
+ self._create_asset_dag_run_queues(dag_id, asset_id, session)
+
+ response = test_client.delete(
+ f"/public/dags/{dag_id}/assets/queuedEvent",
+ )
+
+ assert response.status_code == 204
Review Comment:
Pushed a fix, can you check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
