feluelle commented on a change in pull request #6151: [AIRFLOW-5522] BQ list 
dataset tables operator
URL: https://github.com/apache/airflow/pull/6151#discussion_r326869642
 
 

 ##########
 File path: airflow/gcp/hooks/bigquery.py
 ##########
 @@ -1430,6 +1430,39 @@ def cancel_query(self) -> None:
                               self.running_job_id)
                 time.sleep(5)
 
+    def get_dataset_tables(self, dataset_id: str, project_id: Optional[str] = 
None,
+                           max_results: Optional[int] = None,
+                           page_token: Optional[str] = None) -> Dict[str, 
Union[str, int, List]]:
+        """
+        Get the list of tables for a given dataset.
+        see 
https://cloud.google.com/bigquery/docs/reference/rest/v2/tables/list
 
 Review comment:
   ```suggestion
   
           .. seealso:: 
https://cloud.google.com/bigquery/docs/reference/rest/v2/tables/list
   ```
   Looks better imo. Don't you think so? :)
   
   https://www.sphinx-doc.org/en/1.5/markup/para.html#directive-seealso
   
   It creates colored boxes: 
https://thomas-cokelaer.info/tutorials/sphinx/rest_syntax.html#colored-boxes-note-seealso-todo-and-warnings

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to