potiuk commented on PR #44086: URL: https://github.com/apache/airflow/pull/44086#issuecomment-2484658641
> i don't dispute anything related to the import design discussion. i was just trying to make the point that, all i am doing in this pr, is fixing broken main, essentially. i think the import design issues is really a separate discussion and you might want to transfer the discussion to a discussion, or an issue, or dev list. i'm not involved with AIP-72 at this time -- but i am trying to use breeze for other reasons, and this issue was standing in my way. Yes, but this oss is extra explanation - I am not disputing the PR - just explaining in detail what was the root cause of it and why this PR was needed so that it is captured somewhere. I am not sure why I would multiply number of issues or discussions here. I could do that as well, but It's very relevant - to understand what happened here (as it is not at all obvious). > Once we change the core to airflow-core and have task sdk / core completely isolated (from import POV) — things should be better. FYI @kaxil . Actually just separating airflow core and sdk is not going to help if we keep aliases in `sdk` I am afraid. This is not because we mix "airlfow" and "sdk" - this is because we are lazy importing a modules nested below sdk as part of "sdk.__init__.py". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
