Re: [PR] Remove execution_date and logical_date from DAG Run APIs and Functions, transition to run_id as sole identifier for Airflow 3.0 [airflow]

Mon, 18 Nov 2024 20:16:06 -0800 


uranusjr commented on code in PR #42404:
URL: https://github.com/apache/airflow/pull/42404#discussion_r1847616027


##########
airflow/www/views.py:
##########
@@ -1417,7 +1417,9 @@ def rendered_templates(self, session):
 
         logger.info("Retrieving rendered templates.")
         dag: DAG = get_airflow_app().dag_bag.get_dag(dag_id)
-        dag_run = dag.get_dagrun(logical_date=dttm)
+        dag_run = dag.get_dagrun(
+            select(DagRun.run_id).where(DagRun.logical_date == 
dttm).order_by(DagRun.id.desc()).limit(1)

Review Comment:
   We don’t _need_ to, but should. Similar to the `dag.get_dagrun` call below.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to